Conversation
Contributor
yoavredis
requested changes
Apr 17, 2025
There was a problem hiding this comment.
@rrelledge a few comments:
- If certain certificates are not auto-generated and are later uploaded (optionally) by the customer, then they most likely won't be "self-signed" certs. The whole point of "self-signed" certs is that the system generates them so that the customer won't have to supply its own.
- Per Eng,
ldap_clientandmtls_trusted_caare not auto-generated by the cluster. Thus, the opening paragraph is misleading the reader into thinking that the system auto-generates self-signed certificates for the entire list.
I suggest to:
- Add a 3rd column to the certificate list, indicating auto-generated yes/no
- Explain that the list contains all the supported certificates.
-- Some are auto-generated (self-signed) to be used OOTB, and could be replaced with customer's certs
-- Some are not auto-generated which makes them optional. They must be provided by the customer for using the specific feature they are coupled with.
yoavredis
approved these changes
Apr 20, 2025
yoavredis
left a comment
There was a problem hiding this comment.
@rrelledge now it's clear and accurate :)
LGTM, 10x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DOC-1574